New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Drop for ArrayDeque and implement Copy #29

Open

stjepangolemac wants to merge 1 commit into andylokandy:master from stjepangolemac:master

stjepangolemac commented Oct 8, 2024 •

edited

Loading

Closes #27.

I went with a minimal change set to allow ArrayDeque to implement Copy. Iterator types still implement Drop.

Removed test was failing so I removed it, for now. I see several possible outcomes:

This gets merged as is (in case Drop is not too important for common use cases, it certainly isn't for me)
We put ArrayDeque Drop and Copy implementations behind features, one excluding the other (what to do with this test then?
This PR gets rejected (in which case I'll keep the fork around)


          Remove Drop for ArrayDeque and implement Copy

85598e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet