This repository was archived by the owner on Jan 10, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Redis v2.6 Lua Scripting #11
Open
sjhewitt
wants to merge
17
commits into
andyet:master
Choose a base branch
from
sjhewitt:scripting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the ConfigCache into FeedCache (it no longer references any config) Refactored the Listener thread into its own class Moved all exceptions into exceptions module
Yes there will be separate repo for the Lua scripts. Look in github.com/andyet/thoonk.js in the scripting branch for what has been converted so far. Interestingly, this topic was just raised in the thoonk.js version a few days ago: andyet/thoonk.js#12 |
Yeah, I saw the scripting branch on thoonk.js, but i'm more interested in the python version at the moment, so put my contributions here (plus there's only the one lua script there, which I copied to the scripts folder here) I'm holding off converting the other scripts if there's going to be a change to the contracts to handle versioning. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started converting the python library to use the new Lua scripting (starting with the Job feeds)
This uses the redis-py lua scripting branch discussed here: redis/redis-py#207
As it's possible to do logic within the lua scripts, I've replaced this construct from the contracts:
with this (the
ZRANK
call is no longer necessary)On a side note, is there a plan for maintaining common versions of the lua scripts for all language implementations? (maybe in a separate repo?)