Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/spring-cloud-dataflow] Fixing disabling networkPolicy creation #1

Conversation

andrzejdackiewicz
Copy link
Owner

Description of the change

This PR fixes disabling the creation of networkPolicy when we set networkPolicy.enabled to false.
In my case I want to deploy Spring Cloud Skipper and not create a networkPolicy.

I noticed that when I have (by default) skipper.enabled set to true then by default a networkPolicy is created.
When You add networkPolicy.enabled false, then the networkPolicy is still being created because of the bug in networkpolicy template.

I was using SpringCloudDataFlow HelmChart in 2 versions:

  • 23.1.4
  • 26.5.3
    In both cases the results were the same.

Benefits

It should be possible to disable creation of networkPolicy.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant