[bitnami/spring-cloud-dataflow] Fixing disabling networkPolicy creation #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes disabling the creation of networkPolicy when we set
networkPolicy.enabled
tofalse
.In my case I want to deploy Spring Cloud Skipper and not create a networkPolicy.
I noticed that when I have (by default) skipper.enabled set to true then by default a networkPolicy is created.
When You add networkPolicy.enabled false, then the networkPolicy is still being created because of the bug in networkpolicy template.
I was using SpringCloudDataFlow HelmChart in 2 versions:
In both cases the results were the same.
Benefits
It should be possible to disable creation of networkPolicy.
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm