Removing Problem::get_mesh
#683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this API was removed in favor of `DiscreteProblemInterface::get_mesh` which is used more often in the child classes and gives back the UnstructiredMesh, which is what the application code uses. - VTKOutput and TecplotOutput were updated so they match what is going on in the ExodusIIOutput.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
- Coverage 86.38% 86.37% -0.01%
==========================================
Files 190 190
Lines 12853 12862 +9
==========================================
+ Hits 11103 11110 +7
- Misses 1750 1752 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiscreteProblemInterface::get_meshwhichis used more often in the child classes and gives back the UnstructiredMesh,
which is what the application code uses.
the ExodusIIOutput.