Merge pull request #72 from andrsd/cmake-code-cov

maint: updating code coverage cmake script to work with cmake 3.31+
andrsd · Jan 3, 2025 · 2276005 · 2276005
2 parents b4172a0 + 6659337
commit 2276005
Showing 1 changed file with 8 additions and 18 deletions.
diff --git a/cmake/CodeCoverage.cmake b/cmake/CodeCoverage.cmake
@@ -77,7 +77,10 @@ if(EXODUSIICPP_CODE_COVERAGE)
                 -o ${MERGED_PROFDATA}
         )
 
-        add_custom_target(htmlcov DEPENDS ${PROJECT_BINARY_DIR}/htmlcov/index.html)
+        add_custom_target(htmlcov
+            DEPENDS ${PROJECT_BINARY_DIR}/htmlcov/index.html
+            COMMENT "Open ${PROJECT_BINARY_DIR}/htmlcov/index.html in your browser to view the coverage report."
+        )
         add_custom_command(
             OUTPUT
                 ${PROJECT_BINARY_DIR}/htmlcov/index.html
@@ -94,14 +97,6 @@ if(EXODUSIICPP_CODE_COVERAGE)
                 ${COVERAGE_INFO}
         )
 
-        add_custom_command(
-            TARGET htmlcov
-            POST_BUILD
-            COMMAND ;
-            COMMENT
-                "Open ${PROJECT_BINARY_DIR}/htmlcov/index.html in your browser to view the coverage report."
-        )
-
         function(target_code_coverage TARGET_NAME)
             target_compile_options(${TARGET_NAME} PUBLIC -fprofile-instr-generate -fcoverage-mapping)
             target_link_options(${TARGET_NAME} PUBLIC -fprofile-instr-generate -fcoverage-mapping)
@@ -139,7 +134,10 @@ if(EXODUSIICPP_CODE_COVERAGE)
                 ${EXCLUDE_REGEX}
         )
 
-        add_custom_target(htmlcov DEPENDS ${PROJECT_BINARY_DIR}/htmlcov/index.html)
+        add_custom_target(htmlcov
+            DEPENDS ${PROJECT_BINARY_DIR}/htmlcov/index.html
+            COMMENT "Open ${PROJECT_BINARY_DIR}/htmlcov/index.html in your browser to view the coverage report."
+        )
         add_custom_command(
             OUTPUT
                 ${PROJECT_BINARY_DIR}/htmlcov/index.html
@@ -151,14 +149,6 @@ if(EXODUSIICPP_CODE_COVERAGE)
                 ${COVERAGE_INFO}
         )
 
-        add_custom_command(
-            TARGET htmlcov
-            POST_BUILD
-            COMMAND ;
-            COMMENT
-                "Open ${PROJECT_BINARY_DIR}/htmlcov/index.html in your browser to view the coverage report."
-        )
-
         function(target_code_coverage TARGET_NAME)
             target_compile_options(${TARGET_NAME} PUBLIC -fprofile-arcs -ftest-coverage)
             target_link_options(${TARGET_NAME} PUBLIC -fprofile-arcs -ftest-coverage)