feat(ytdl-mpv)!: split cache main table in main + meta #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andros21
force-pushed
the
sqlite-cache
branch
from
928f07c to
f417dfa
Compare
andros21
force-pushed
the
sqlite-cache
branch
from
f417dfa to
14ab550
Compare
andros21
force-pushed
the
sqlite-cache
branch
2 times, most recently
from
8c2d9a2 to
f4fe67d
Compare
andros21
changed the title
**breaking changes** no more UNIQUE title constrain, only SELECT title for a given query with DISTINCT Flush cache db please!
start using the real power of relational database related changes: * this will allow to update metadata for a given video id separately from main table that will contain only the search id and the video id (foreign key) * the update strategy of meta table is INSERT for new records and bulk UPDATE for already present ones, without history * DISTINCT SELECT when searching inside playlist is not needed anymore cause selecting inside meta table that has primary key enforcement over video id * check db initialization and tables presence at the script start and not only when trying to cache an element
andros21
force-pushed
the
sqlite-cache
branch
from
f4fe67d to
180001d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking changes
start using the real power of relational database ⚡
related changes:
this will allow updating metadata for a given video id
separately from main table that will contain only the search
id and the video id (foreign key)
the update strategy of meta table is INSERT for new records
and bulk UPDATE for already present ones, without history
DISTINCT SELECT when searching inside playlist is not needed
any more cause selecting inside meta table that has primary
key enforcement over video id
check db initialization and tables presence at the script
start and not only when trying to cache an element
Important
Flush cache db or manually remove it please before
make install