Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused deps using cargo-udeps #737

Merged
merged 2 commits into from
Dec 23, 2024
Merged

chore: remove unused deps using cargo-udeps #737

merged 2 commits into from
Dec 23, 2024

Conversation

joemonem
Copy link
Contributor

@joemonem joemonem commented Dec 23, 2024

Motivation

Remove unused dependencies.
Resolve this warning: unused manifest key: lib.testing

Implementation

Used cargo-udeps which gave the following results:
Screenshot 2024-12-23 at 12 12 45

Testing

No tests were affected

Version Changes

None

Notes

I left the unused local deps in the testing folders.
Most of the false positives were test-case

Future work

None

Summary by CodeRabbit

  • Bug Fixes

    • Removed outdated dependencies across multiple packages, including cw4, cw3, cw-json, andromeda-data-storage, serde-cw-value, cosmrs, prost-types, secp256k1, and reqwest.
  • New Features

    • Updated package versions for andromeda-kernel and andromeda-std.
    • Removed the -testing feature from the andromeda-fungible-tokens package.

These changes streamline the project by eliminating unnecessary dependencies, potentially improving performance and maintainability.

@joemonem joemonem requested a review from crnbarr93 December 23, 2024 10:24
Copy link
Contributor

coderabbitai bot commented Dec 23, 2024

Walkthrough

This pull request involves multiple modifications to Cargo.toml files across various packages in the Andromeda project. The changes primarily focus on removing specific dependencies such as cw4, cw3, cw-json, cosmrs, prost-types, secp256k1, and serde-cw-value from different packages. Additionally, some package versions have been incrementally updated, like andromeda-kernel and andromeda-std. The modifications appear to be part of a dependency cleanup and version management effort.

Changes

File Changes
contracts/accounts/andromeda-fixed-multisig/Cargo.toml Removed cw4 and cw3-fixed-multisig dependencies
contracts/data-storage/andromeda-form/Cargo.toml Removed cw-json dependency
contracts/os/andromeda-ibc-registry/Cargo.toml Removed andromeda-data-storage dependency
contracts/os/andromeda-kernel/Cargo.toml Updated version to 1.2.0-b.1, removed serde-cw-value dependency
ibc-tests/Cargo.toml Removed cosmrs and prost-types dependencies
packages/andromeda-finance/Cargo.toml Removed cw3 and cw4 dependencies
packages/andromeda-testing-e2e/Cargo.toml Removed secp256k1, cosmrs, and reqwest dependencies
packages/std/Cargo.toml Updated version to 1.5.0-b.2, removed cw3 dependency
packages/andromeda-fungible-tokens/Cargo.toml Removed testing feature from [lib] section

Possibly related PRs

Suggested reviewers

  • crnbarr93

Poem

🐰 Hop, hop, dependencies go away,
Cleaning up our Cargo.toml today!
Removing crates with a swift paw swipe,
Streamlining code, making it just right.
A rabbit's refactor, precise and clean! 🔧


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8bc89c4 and 99a8f9e.

📒 Files selected for processing (2)
  • packages/andromeda-finance/Cargo.toml (0 hunks)
  • packages/andromeda-fungible-tokens/Cargo.toml (0 hunks)
💤 Files with no reviewable changes (2)
  • packages/andromeda-fungible-tokens/Cargo.toml
  • packages/andromeda-finance/Cargo.toml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@crnbarr93 crnbarr93 added the ci: skip-changelog Skips the changelog check in CI label Dec 23, 2024
@crnbarr93 crnbarr93 merged commit 5a250de into main Dec 23, 2024
11 checks passed
@crnbarr93 crnbarr93 deleted the unused-deps branch December 23, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: skip-changelog Skips the changelog check in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants