-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: amount sold incorrect for tiers with limits (backport #603) #615
Conversation
(cherry picked from commit 60d6ca6) # Conflicts: # contracts/non-fungible-tokens/andromeda-crowdfund/src/mock.rs # contracts/non-fungible-tokens/andromeda-crowdfund/src/state.rs
Cherry-pick of 60d6ca6 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Motivation
These changes fix an issue with crowdfund tiers that had no limit not updating their amount sold correctly.
Implementation
Moved updating tier/amount sold to outside check for limit.
Testing
Added a case in the integration test to ensure the
GetTiers
query returns correct values.Summary by CodeRabbit
This is an automatic backport of pull request #603 done by [Mergify](https://mergify.com).