-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rates Queries Accessibility #535
Conversation
WalkthroughThe recent changes enhance the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/std/macros/src/lib.rs (1 hunks)
Additional comments not posted (1)
packages/std/macros/src/lib.rs (1)
158-172
: Conditional Compilation for Rates Variants Looks Good!The use of the
cfg
attribute to conditionally compile theRates
andAllRates
variants based on the "rates" feature is a sound approach. This change enhances modularity and aligns with feature management best practices.Ensure that the "rates" feature is correctly defined and managed in your build configuration to prevent any compilation issues.
Verification successful
Feature Flag for Rates is Correctly Defined
The "rates" feature is properly defined and utilized across multiple modules and contracts in the project. This confirms that the conditional compilation in the code snippet is supported by the build configuration.
- Verified in
packages/andromeda-modules/Cargo.toml
and several otherCargo.toml
files.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the "rates" feature is defined in the build configuration. # Test: Check for the definition of the "rates" feature in Cargo.toml or other relevant configuration files. rg 'features\s*=\s*.*rates' -A 3Length of output: 2487
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
Files selected for processing (1)
- packages/std/Cargo.toml (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/std/Cargo.toml
Motivation
Closes #532
Implementation
Merged rates-specific variants on
andr_query
the same way asandr_exec
Testing
Uploaded the following contract and the queries appear as expected
Version Changes
Bumped
std
by 0.0.1Summary by CodeRabbit
Rates
andAllRates
variants are only included when the "rates" feature is enabled, preventing potential issues when the feature is inactive.andromeda-std
from 1.1.0 to 1.1.1 to reflect minor improvements and ensure compatibility.