[Validator Staking ADO]: Query unbonding period #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemonem
reviewed
Mar 13, 2024
| } | ||
|
|
||
| pub fn on_validator_unstake(deps: DepsMut, msg: Reply) -> Result<Response, ContractError> { | ||
| let attributes = &msg.result.unwrap().events[0].attributes; |
There was a problem hiding this comment.
Are we sure that events can't be an empty vector? If not we could use events.first() instead to cover that case.
There was a problem hiding this comment.
Events can not be an empty vector as it is called from a reply entry point. Only if undelegate msg executed successfully, on_validator_unstake is called with msg which contains an event for the undelegate msg
crnbarr93
changed the title
crnbarr93
requested changes
Mar 14, 2024
crnbarr93
approved these changes
Mar 14, 2024
crnbarr93
deleted the
feature/staking-withdraw-funds-with-completion-time
branch
crnbarr93
pushed a commit
that referenced
this pull request
Mar 18, 2024
* Feature/staking state management (#298) * created validator staking contract in finance subdirectory * added contract instantiation implementation and created state management * added schema * updated andromeda finance package's toml file to use staking feature of cosmwasm std * removed unncessary macro and renamed improper helper function * fixed issues for pr * Feature/staking execute stake (#300) * added execute and query entrypoint for validator staking * added integration test * added unit test for validator staking * fixed linting error * fixed clippy error * Feature/staking claim rewards (#304) * added execute and query entrypoint for validator staking * added integration test * added unit test for validator staking * fixed linting error * fixed clippy error * undelegate functionality added * test case added for unstaking with invalid validator and owner * claim reward function added * lint error fixed and optimized * updated some validation code with ensure! macro * added AMP handler & updated validator staking unit test mock info to use owner * unauthorized unit test added for claim reward and unstake * Feature/staking withdraw unstaked tokens (#310) * added execute and query entrypoint for validator staking * added integration test * added unit test for validator staking * fixed linting error * fixed clippy error * undelegate functionality added * test case added for unstaking with invalid validator and owner * claim reward function added * lint error fixed and optimized * updated some validation code with ensure! macro * updated integration test to reflect the effect of undelegation * added AMP handler & updated validator staking unit test mock info to use owner * unauthorized unit test added for claim reward and unstake * merged with feature/staking branch & added WithdrawFund message * added withdraw fund handler * query for unstaked tokens added * renamed msgs for clarity * [Validator Staking ADO]: Query unbonding period (#323) * unstaking history saved to storage * removed stargate feature from validator staking * adjusted chrono version to 3 for rust version compatibility * added doc for validator staking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Staking ADO is currently using static unbonding period for calculating completion time of the unstaking process. The original issue is created here.
Implementation
Implementing custom message using proto to get staking params was not worthy for this case, as integration test becomes complicated. Thus, the reply is defined for
Undelegatemessage to get the event details which contains completion time and fund information.UNSTAKING_QUEUEinreplyentry point (inon_validator_unstakefunction).Testing
tests-integration/tests/validator_staking.rsis updated from using static unbonding period to use completion time.