-
Notifications
You must be signed in to change notification settings - Fork 5k
Fix previews for JetLaggedScreen and HeartRateCard #1548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The HeartRateGraph needs the theme. This fixes the previews to make sure the JetLaggedTheme theme is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @diegopl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue where previews for JetLaggedScreen
and HeartRateCard
were not displaying correctly. The primary change involves ensuring that these previews are rendered within the JetLaggedTheme
to accurately reflect the intended UI. The original @Preview
annotation was removed from the composables and replaced with a new private composable function annotated with @Preview
that wraps the original composable with the JetLaggedTheme
.
Highlights
- Preview Fix: The previews for
JetLaggedScreen
andHeartRateCard
now correctly use theJetLaggedTheme
. - Code Organization: The
@Preview
annotation was moved to a new private composable function that wraps the original composable with theJetLaggedTheme
.
Changelog
- JetLagged/app/src/main/java/com/example/jetlagged/JetLaggedScreen.kt
- Removed the
@MultiDevicePreview
annotation from theJetLaggedScreen
composable. - Added a new private composable function
JetLaggedScreenPreview
annotated with@MultiDevicePreview
that wrapsJetLaggedScreen
withJetLaggedTheme
.
- Removed the
- JetLagged/app/src/main/java/com/example/jetlagged/heartrate/HeartRateCard.kt
- Removed the
@Preview
annotation from theHeartRateCard
composable. - Added a new private composable function
HeartRateCardPreview
annotated with@Preview
that wrapsHeartRateCard
withJetLaggedTheme
.
- Removed the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A preview's gentle art,
Theme's embrace, a brand new start,
JetLagged's design,
In previews shine,
A visual, playing its part.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request addresses an issue where previews for JetLaggedScreen
and HeartRateCard
were not using the JetLaggedTheme
. The changes involve moving the @MultiDevicePreview
and @Preview
annotations to separate preview functions and wrapping the composables with JetLaggedTheme
in those functions. This ensures that the previews are rendered with the correct theme applied.
Merge Readiness
The pull request appears to correctly address the issue of previews not using the correct theme. The changes are straightforward and improve the visibility of the composables in the IDE. I am unable to directly approve the pull request, and other reviewers should review and approve this code before merging. There are no critical or high severity issues, so the pull request is likely ready to be merged once other reviewers have approved it.
@Composable | ||
fun HeartRateCard( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HeartRateGraph needs the theme. This fixes the previews to make sure the JetLaggedTheme theme is used.