Attempt to add better error reporting when espresso device is used without INTERNET permission. #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_592039096
branch
from
b58e773 to
5b99850
Compare
…thout INTERNET permission. Currently if a test attempts to use espresso-device on an emulator without the INTERNET permission, they will see a cryptic error like ``` Caused by: java.net.SocketException: socket failed: EPERM (Operation not permitted) ``` This change adds an explicit check to see if the current process has the INTERNET permission, and if it doesn't, throw a specific error message. This change also adds a uses-permission INTERNET entry to espresso-device's manifest. This should help grant the INTERNET permission automatically in development environments where the build system auto-merges manifest permission entries into the target process manifest. PiperOrigin-RevId: 592259503
copybara-service
bot
force-pushed
the
piper_592039096
branch
from
5b99850 to
f84116f
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
f84116f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to add better error reporting when espresso device is used without INTERNET permission.
Currently if a test attempts to use espresso-device on an emulator without the INTERNET
permission, they will see a cryptic error like
This change adds an explicit check to see if the current process has the INTERNET permission,
and if it doesn't, throw a specific error message.
This change also adds a uses-permission INTERNET entry to espresso-device's manifest.
This should help grant the INTERNET permission automatically in development environments
where the build system auto-merges manifest permission entries into the target process
manifest.