Add a check for 32bit Windows to target nightly Rust. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 1 1
Lines 698 698
=======================================
Hits 695 695
Misses 3 3 ☔ View full report in Codecov by Sentry. |
Previously, compiling with non-nightly Rust meant 32bit Windows would fail to generate bindings - bindgen will not use the "thiscall" ABI unless using nightly Rust. The bindings would therefore have (almost) nothing in them, so any calls would fail. Now at least there will be a warning, and if using nightly Rust, this will work!
andriyDev
force-pushed
the
fix-32bit-windows
branch
from
a8d28e3 to
19072d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, compiling with non-nightly Rust meant 32bit Windows would fail to generate bindings - bindgen will not use the "thiscall" ABI unless using nightly Rust. The bindings would therefore have (almost) nothing in them, so any calls would fail. Now at least there will be a warning, and if using nightly Rust, this will work!
Fixes #3.