Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only call localCheck when time is involved #670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sturdynut
Copy link

This is an attempt to fix this issue:
#648

After looking into the issue, it appears as though the localeCheck function is causing the issue. From what I can tell, it should only apply when there is a time to consider. I've moved the localCheck into the branching logic for addCoreFormats where it is also checking for time.

I wrote a test that takes both issues mentioned into account, where a date of December 1 is showing up as January 12th, as well as the original issue where "Invalid Date" was being returned when creating a date without time using dot notation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant