Increase TLD maximum length #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user with a .construction (length 13) Email pointed this out. I'm updating it to 18, because there's TLDs like https://nic.travelersinsurance/
|
At which point I honestly don't see much of the point of keeping the length limit at all in the first place. Back in the days where TLDs were all short it may have been useful to prevent errors. But in the end, the only true way to test if an email address is valid is to send it a mail anyways |
andrewcmyers
approved these changes
Sep 17, 2024
|
@andrewcmyers Thanks! Are you also able to deploy this soon? @piegamesde I opted for minimal changes, but I agree. Considering this is merged already now I'm not inclined to make another PR though :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user with a .construction (length 13) Email pointed this out: NixOS/SC-election-2024#6
I'm updating it to 18, because there's TLDs like https://nic.travelersinsurance/, though in theory you can have TLDs up to length 63, see https://stackoverflow.com/a/22038535.