changes in usePagination

[Isthisanmol]

No description provided.

[cloudflare-workers-and-pages]

Deploying packrat with    Cloudflare Pages

Latest commit:	088c6ea
Status:	✅  Deploy successful!
Preview URL:	https://ff384daf.packrat.pages.dev
Branch Preview URL:	https://fix-global-items-page-on-nat.packrat.pages.dev

View logs

[github-actions]

❌ Tests failed for this pull request. 😞

View Test Workflow

[github-actions]

Android APK build completed!
You can download the APK file from the following link:
https://github.com/andrew-bierman/PackRat/actions/runs/9367907281#artifacts

[EngrAJ8888]

Hi @Isthisanmol - the mobile app crashes while trying to access the Items Page. I've included a video for reference. Thanks for looking into this!

16.mp4

[Isthisanmol]

Hi @Isthisanmol - the mobile app crashes while trying to access the Items Page. I've included a video for reference. Thanks for looking into this!
16.mp4

Please check for the latest commit and update if there are any issues.

[EngrAJ8888]

Hi @Isthisanmol, I've noticed a few areas that need updates:

• Can we adjust the item text so it doesn't overlap onto the next line? For example, the word "Essentials" has its 'S' on the next line.
  

• I selected 10 items, but the table only previews 7. Please update.

• Please adjust the layout so that the "Choose a value" text doesn't overlap with the option menu below it.

• Update the "Choose a value" option so that it doesn't occupy the entire screen. Perhaps we could make it a small pop-up instead.
  

Thanks again!

[andrew-bierman]

Hi @Isthisanmol, I've noticed a few areas that need updates:

• Can we adjust the item text so it doesn't overlap onto the next line? For example, the word "Essentials" has its 'S' on the next line.

• I selected 10 items, but the table only previews 7. Please update.

• Please adjust the layout so that the "Choose a value" text doesn't overlap with the option menu below it.

• Update the "Choose a value" option so that it doesn't occupy the entire screen. Perhaps we could make it a small pop-up instead.

Thanks again!

I merged this so it did not get stale, but please see these comments @Isthisanmol when you are free :)

[Isthisanmol]

Hi @Isthisanmol, I've noticed a few areas that need updates:

• Can we adjust the item text so it doesn't overlap onto the next line? For example, the word "Essentials" has its 'S' on the next line.

• I selected 10 items, but the table only previews 7. Please update.
• Please adjust the layout so that the "Choose a value" text doesn't overlap with the option menu below it.
• Update the "Choose a value" option so that it doesn't occupy the entire screen. Perhaps we could make it a small pop-up instead.

Thanks again!

I merged this so it did not get stale, but please see these comments @Isthisanmol when you are free :)

Hi, @EngrAJ8888 Fixed these already in PR: #984 but the last one is a component that uses tamagui sheet and this dropdown is used in the entire app. Should I make another component for this one only?

[andrew-bierman]

@Isthisanmol you can keep current sheet version for now but fix any remaining issues AJ reported for this.

Let’s discuss a separate PR that would be tamagui dropdown on web and zeego dropdown on native. It will be like the component we have that uses popover for web and zeego for native I imagine.

[Isthisanmol]

@Isthisanmol you can keep current sheet version for now but fix any remaining issues AJ reported for this.

Let’s discuss a separate PR that would be tamagui dropdown on web and zeego dropdown on native. It will be like the component we have that uses popover for web and zeego for native I imagine.

Thank you @andrew-bierman for the suggestion! I think creating a component that uses Tamagui Dropdown on web and Zeego Dropdown on native platforms would indeed streamline our UI/UX across different environments. Should I implement that?