Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/chat #975

Merged
merged 11 commits into from
Jun 6, 2024
Merged

Enhance/chat #975

merged 11 commits into from
Jun 6, 2024

Conversation

pinocchio-life-like
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Jun 1, 2024

❌ Tests failed for this pull request. 😞

View Test Workflow

Copy link

cloudflare-workers-and-pages bot commented Jun 1, 2024

Deploying packrat with  Cloudflare Pages  Cloudflare Pages

Latest commit: c0c2bab
Status: ✅  Deploy successful!
Preview URL: https://d99b7f65.packrat.pages.dev
Branch Preview URL: https://enhance-chat.packrat.pages.dev

View logs

Copy link

github-actions bot commented Jun 1, 2024

iOS app build failed!
Please check the workflow logs for more details on the build failure.

@EngrAJ8888
Copy link
Collaborator

Hi @pinocchio-life-like , Thanks for the update! Everything looks great. However, I'd like to suggest one addition. When I tried minimizing the chat (by clicking the chat icon only), I noticed that the text I entered disappeared. Could we update this so that the chat history is retained? Perhaps we could have the "X" button on top clear the chat history instead.
image

@pinocchio-life-like
Copy link
Collaborator Author

Hi @EngrAJ8888 which text do you mean exactly? the one on the input field or those you have already sent?

if its the one you have already sent, since the backend is returning error, sent messages will not be retained. but if you mean the text field being cleared, I will address that. let me know!

@EngrAJ8888
Copy link
Collaborator

Hi @pinocchio-life-like , I was referring to the text I inputted into the chat AI. I've also attached a photo for reference.
image

Does this mean we'll leave it as is for now, considering it's a backend issue? Thanks!

@pinocchio-life-like
Copy link
Collaborator Author

@EngrAJ8888 Yes, I believe.

Screenshot 2024-06-03 140118

I have left message for on discord. check that.

@EngrAJ8888
Copy link
Collaborator

Hi @pinocchio-life-like - Please refer to the video for clarification on the issue I raised. The text should remain if I only minimize the chat box. However, if the problem lies in the backend, we can go ahead and close this out. Thank you!

15.mp4

@pinocchio-life-like
Copy link
Collaborator Author

@EngrAJ8888 Yes I am sure that this is OpenAI API key not being set for the backend. If this suffices the issue you raised you may close this. Its also okay if you dont since I am working on other enhancements regarding chat.

@pinocchio-life-like
Copy link
Collaborator Author

Update, it works now.

@EngrAJ8888
Copy link
Collaborator

Hi @pinocchio-life-like - thanks for the update! It's looking great!

@andrew-bierman - this is good for merging.

@andrew-bierman andrew-bierman merged commit c0c2bab into andrew_testing Jun 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants