Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage improvements #969

Closed
wants to merge 9 commits into from
Closed

Homepage improvements #969

wants to merge 9 commits into from

Conversation

mikeCyb
Copy link
Collaborator

@mikeCyb mikeCyb commented May 27, 2024

Improvements

  1. Click functionality on Packrat Logo
  2. Quick action text improvements
  3. Home page search input adjusted with the width of navbar

Copy link

github-actions bot commented May 27, 2024

❌ Tests failed for this pull request. 😞

View Test Workflow

Copy link

github-actions bot commented May 27, 2024

iOS app build failed!
Please check the workflow logs for more details on the build failure.

@EngrAJ8888
Copy link
Collaborator

Hi @mikeCyb - please see below for items that needs update.

  • I noticed the quick action button has become larger. Can we revert it to its previous size but enhance the visibility of the text?
  • Kindly refine the search bar by reducing its width while keeping the background picture unchanged.
  • Additionally, can we implement the click functionality on the "PackRat" word as well?

Thank you!

@mikeCyb
Copy link
Collaborator Author

mikeCyb commented May 27, 2024

@EngrAJ8888 Thanks for the feedback it will get fixed.

Copy link

cloudflare-workers-and-pages bot commented May 27, 2024

Deploying packrat with  Cloudflare Pages  Cloudflare Pages

Latest commit: cf59f71
Status: ✅  Deploy successful!
Preview URL: https://a375366f.packrat.pages.dev
Branch Preview URL: https://homepage-improvement.packrat.pages.dev

View logs

@mikeCyb
Copy link
Collaborator Author

mikeCyb commented May 27, 2024

hey @EngrAJ8888 I have modified it as you said. Check it now and let me hear your feedback again.

@EngrAJ8888
Copy link
Collaborator

Hi @mikeCyb, thanks for the update! This looks good to me, and no further updates are needed. Appreciate your work!

@andrew-bierman - this is ready for merging.

Thank you both!

@EngrAJ8888
Copy link
Collaborator

Hi @mikeCyb , thanks for the update!

@andrew-bierman - this looks good for merging.

Thank you both!

@JewelTee JewelTee requested a review from andrew-bierman June 7, 2024 09:43
@EngrAJ8888
Copy link
Collaborator

Hi @mikeCyb , there's an issue that needs to be addressed before we can merge this PR. Could you please take a look. Thank you!

@EngrAJ8888
Copy link
Collaborator

Closing this one. The new PR for homepage improvements is #993

@EngrAJ8888 EngrAJ8888 closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants