Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config for android local build #936

Merged
merged 6 commits into from
May 16, 2024

Conversation

Tadjaur
Copy link
Collaborator

@Tadjaur Tadjaur commented May 15, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented May 15, 2024

Deploying packrat with  Cloudflare Pages  Cloudflare Pages

Latest commit: d6f9c01
Status: ✅  Deploy successful!
Preview URL: https://3abb0242.packrat.pages.dev
Branch Preview URL: https://fix-android-build-2.packrat.pages.dev

View logs

Comment on lines 15 to 17
EXPO_PUBLIC_CLIENT_URL: ${{ vars.EXPO_PUBLIC_CLIENT_URL }}
EXPO_PUBLIC_API_URL: ${{ vars.EXPO_PUBLIC_API_URL }}
EXPO_PUBLIC_MAPBOX_ACCESS_TOKEN: ${{ secrets.EXPO_PUBLIC_MAPBOX_ACCESS_TOKEN }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-bierman These variable must be defined.
here I'm using some vars keyword but if these variables are all defined as secrets just let me know and I will update them.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will define these as secrets just to keep everything in the same place, github secrets will be updated with these values momentarily

Copy link
Collaborator Author

@Tadjaur Tadjaur May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Comment on lines +3 to +7
EXPO_PUBLIC_CLIENT_URL="Your client url"
EXPO_PUBLIC_API_URL="Your api url"
EXPO_PUBLIC_MAPBOX_ACCESS_TOKEN="Your api key, starts with pk..."
EXPO_PUBLIC_ANDROID_CLIENT_ID="962352557394-........................apps.googleusercontent.com"
EXPO_PUBLIC_IOS_CLIENT_ID="962352557394-........................apps.googleusercontent.com"
Copy link
Collaborator Author

@Tadjaur Tadjaur May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only environment variables in use are defined here.

Copy link

github-actions bot commented May 15, 2024

❌ Tests failed for this pull request. 😞

View Test Workflow

Copy link

github-actions bot commented May 15, 2024

Android APK build completed!
You can download the APK file from the following link:
https://github.com/andrew-bierman/PackRat/actions/runs/9104525383#artifacts

@Tadjaur Tadjaur force-pushed the fix/android-build-2 branch from e32155e to ff336df Compare May 15, 2024 17:42
Copy link
Owner

@andrew-bierman andrew-bierman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job :)

@andrew-bierman andrew-bierman merged commit 277e705 into andrew_testing May 16, 2024
25 of 29 checks passed
@andrew-bierman andrew-bierman deleted the fix/android-build-2 branch May 16, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants