-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix config for android local build #936
Conversation
Deploying packrat with Cloudflare Pages
|
.github/workflows/expo.build.yml
Outdated
EXPO_PUBLIC_CLIENT_URL: ${{ vars.EXPO_PUBLIC_CLIENT_URL }} | ||
EXPO_PUBLIC_API_URL: ${{ vars.EXPO_PUBLIC_API_URL }} | ||
EXPO_PUBLIC_MAPBOX_ACCESS_TOKEN: ${{ secrets.EXPO_PUBLIC_MAPBOX_ACCESS_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrew-bierman These variable must be defined.
here I'm using some vars
keyword but if these variables are all defined as secrets just let me know and I will update them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will define these as secrets just to keep everything in the same place, github secrets will be updated with these values momentarily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
EXPO_PUBLIC_CLIENT_URL="Your client url" | ||
EXPO_PUBLIC_API_URL="Your api url" | ||
EXPO_PUBLIC_MAPBOX_ACCESS_TOKEN="Your api key, starts with pk..." | ||
EXPO_PUBLIC_ANDROID_CLIENT_ID="962352557394-........................apps.googleusercontent.com" | ||
EXPO_PUBLIC_IOS_CLIENT_ID="962352557394-........................apps.googleusercontent.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only environment variables in use are defined here.
❌ Tests failed for this pull request. 😞 |
Android APK build completed! |
e32155e
to
ff336df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job :)
No description provided.