Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trip improvments #917

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

taronaleksanian
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented May 9, 2024

❌ Tests failed for this pull request. 😞

View Test Workflow

Copy link

Deploying packrat with  Cloudflare Pages  Cloudflare Pages

Latest commit: f962c75
Status: ✅  Deploy successful!
Preview URL: https://01631316.packrat.pages.dev
Branch Preview URL: https://issue-881-trip-improvments.packrat.pages.dev

View logs

Copy link

github-actions bot commented May 9, 2024

Android APK build completed!
You can download the APK file from the following link:
https://github.com/andrew-bierman/PackRat/actions/runs/9013324363#artifacts

@EngrAJ8888
Copy link
Collaborator

Hi @taronaleksanian - The update looks great! I'd like to add that trip details should be accurately reflected when viewing trips. I created a trip with Biking and Running as activities, but upon checking, the Activity section only displays the word "Trip" for both. Could you please take a look? I've attached a photo for reference. Thank you!

image
image

@taronaleksanian
Copy link
Collaborator Author

Sure I will check it thanks

@andrew-bierman
Copy link
Owner

Good stuff, this would be cool if it filtered the search bar and nearby cards based on activity type ie selecting biking should not show a standard footpath.

I believe we can update osm queries to optionally accept this new type

@taronaleksanian
Copy link
Collaborator Author

Yeah, great idea will implement it too!

@andrew-bierman andrew-bierman merged commit 6a1e49a into andrew_testing May 10, 2024
30 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants