Type Fix inisde UI directory #757
Conversation
|
Your Render PR Server URL is https://packrat-dev-pr-757.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cnqj16nsc6pc73e3lq3g. |
Deploying packrat with
|
| Latest commit: |
0f512e0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e1066d87.packrat.pages.dev |
| Branch Preview URL: | https://eliyas-type-fix.packrat.pages.dev |
|
Your Render PR Server at https://packrat-dev-pr-757.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-cnqj16nsc6pc73e3lq3g. |
|
Let's rebase this and get it merged, same with the other type PR |
|
❌ Tests failed for this pull request. 😞 |
pinocchio-life-like
force-pushed
the
eliyas/type_fix
branch
from
44264a5 to
5010884
Compare
|
Android APK build failed! |
pinocchio-life-like
force-pushed
the
eliyas/type_fix
branch
from
d13faa5 to
c6efbe8
Compare
@andrew-bierman I did done rebase this, and added some updates. |
|
Also there seems to be a lot of new type errors like inside server directory. I will rebase the already existing fixes and I will continue with the rest as well. |
|
@JewelTee just double check everything looks good on site when you get a chance |
|
@pinocchio-life-like hi! I tested this PR and I encountered issues that had been resolved and merged to andrew_testing branch. |
|
@JewelTee Hi, can you explain more please? |
|
@pinocchio-life-like I sent you a dm. Please check thanks! |
|
@andrew-bierman This has been updated, everything looks good now. |
Since Most of the type errors that are in UI directory come from "tamagui", I have tried many solutions but the right possible way I found is to update the type inside the module but it is inside the node_modules, and that is not possible. so I tried to avoid most of the type fixes by doing workarounds. but others I have set proper types on it and now we don't have type issue inside UI library.
check and let me know.