Create a map package from existing map data. #1193
Conversation
|
Android APK build completed! |
|
❌ Tests failed for this pull request. 😞 |
|
Tauri build completed! |
|
iOS IPA build completed! |
Deploying packrat with
|
| Latest commit: |
dbb7cb1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c154d67.packrat.pages.dev |
| Branch Preview URL: | https://fix-map.packrat.pages.dev |
| console.log('newResponse', newResponse); | ||
|
|
||
| // return newResponse; | ||
| return ctx.json(newResponse, 200); |
There was a problem hiding this comment.
@MuhammadHassan03 @andrew-bierman I deleted this line because the response is not a json and should not be converted to json value. we expect an image.
|
/refresh-lockfile |
|
Starting lockfile refresh... |
|
No changes to commit. |
|
Lockfile refresh process completed. |
|
This looks good to me. Nice work The main goal I wanted to accomplish here was a more unified api for our maps, which I think this is good start for. We will be building out some more mapping features soon so this is intended to set us up for success and as much simplicity as we can get with this feature |
There was a problem hiding this comment.
Good job, only I think we can do a few improvements. I think it would be better if we keep the library specific code into packages/map workspaces and more application related stuff move to our app folder app/features/map.
@andrew-bierman I'm switching on this task, so I'll handle it
|
@taronaleksanian @andrew-bierman what left do we need on this pr for it to be merged? |
@Tadjaur unifing the web and mobile maps, I'm working on it you can check other tasks |
I have high priority issues to fix if you available please let me know, I'll provide details so you can continue with this, if I won't finish with this by that time |
What is done in this pr:
I'm still working on merging native map and web map logic to reduce platform specific code. But as the map already works on the web and native platform ( tested on android ), I wanted to do this first pr to get review.