Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import from bucket for global items #1156

Merged
merged 18 commits into from
Aug 24, 2024
Merged

Import from bucket for global items #1156

merged 18 commits into from
Aug 24, 2024

Conversation

pinocchio-life-like
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

❌ Tests failed for this pull request. 😞

View Test Workflow

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 5, 2024 •
edited
Loading

Deploying packrat with  Cloudflare Pages  Cloudflare Pages

Latest commit: db7cdbe
Status:⚡️  Build in progress...

View logs

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

Tauri build completed!
You can download the build artifacts from the following link:
https://github.com/andrew-bierman/PackRat/actions/runs/10536417585#artifacts

@andrew-bierman
Copy link
Owner

Good work here, gonna drop a few clean up comments but this is quite close

andrew-bierman
andrew-bierman requested changes Aug 8, 2024
View reviewed changes
Copy link
Owner

@andrew-bierman andrew-bierman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, some file structure stuff and cleanup remaining

server/src/controllers/item/importFromBucket.ts Show resolved Hide resolved
server/src/routes/index.ts Outdated Show resolved Hide resolved
@andrew-bierman
Copy link
Owner

@MuhammadHassan03 pls make new branch from here and rebase. @pinocchio-life-like's computer is in the shop

@github-actions github-actions bot added the test label Aug 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

Android APK build failed!
Please check the workflow logs for more details on the build failure.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

iOS IPA build completed!
You can download the iOS IPA from the following link:
https://github.com/andrew-bierman/PackRat/actions/runs/10536417583#artifacts

andrew-bierman
andrew-bierman approved these changes Aug 24, 2024
View reviewed changes
Copy link
Owner

@andrew-bierman andrew-bierman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here, we need to update env example and the discord I believe

@andrew-bierman andrew-bierman merged commit 6af4ce4 into andrew_testing Aug 24, 2024
28 of 31 checks passed
@andrew-bierman andrew-bierman deleted the feat/integrate_servers branch August 24, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-bierman andrew-bierman andrew-bierman approved these changes

Assignees
No one assigned
Labels
AnyChange api backend client frontend root test tests-failure❤️ tests-skipped❤️ vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinocchio-life-like @andrew-bierman