-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/preview version of api #1130
Conversation
❌ Tests failed for this pull request. 😞 |
Deploying packrat with Cloudflare Pages
|
Android APK build completed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just use the env shim script we have but for backend it will generate .preview.vars and .vars for prod? Might be easier to maintain if we can get it functional. Then we could put the wrangler.toml on github if we can keep secrets out of it https://developers.cloudflare.com/workers/configuration/environment-variables/#add-environment-variables-via-wrangler
74a1f96
to
29a39fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im good with these changes overall, i do think we might want to consider my comment about using the vars files so that we can keep wrangler.toml in source and not have to echo each value in
No description provided.