Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/preview version of api #1130

Merged
merged 11 commits into from
Jul 26, 2024
Merged

Conversation

taronaleksanian
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Jul 23, 2024

❌ Tests failed for this pull request. 😞

View Test Workflow

Copy link

cloudflare-workers-and-pages bot commented Jul 23, 2024

Deploying packrat with  Cloudflare Pages  Cloudflare Pages

Latest commit: 29a39fe
Status: ✅  Deploy successful!
Preview URL: https://c27e944e.packrat.pages.dev
Branch Preview URL: https://feat-preview-version-of-api.packrat.pages.dev

View logs

Copy link

github-actions bot commented Jul 23, 2024

Android APK build completed!
You can download the APK file from the following link:
https://github.com/andrew-bierman/PackRat/actions/runs/10093197369#artifacts

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just use the env shim script we have but for backend it will generate .preview.vars and .vars for prod? Might be easier to maintain if we can get it functional. Then we could put the wrangler.toml on github if we can keep secrets out of it https://developers.cloudflare.com/workers/configuration/environment-variables/#add-environment-variables-via-wrangler

@taronaleksanian taronaleksanian force-pushed the feat/preview-version-of-api branch from 74a1f96 to 29a39fe Compare July 25, 2024 11:21
Copy link
Owner

@andrew-bierman andrew-bierman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im good with these changes overall, i do think we might want to consider my comment about using the vars files so that we can keep wrangler.toml in source and not have to echo each value in

@taronaleksanian taronaleksanian merged commit fbdbd5c into andrew_testing Jul 26, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants