Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native map download #1114

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

Tadjaur
Copy link
Collaborator

@Tadjaur Tadjaur commented Jul 21, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Jul 21, 2024

Deploying packrat with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7387eed
Status: ✅  Deploy successful!
Preview URL: https://a54ac8c7.packrat.pages.dev
Branch Preview URL: https://1109-profile-screen-ui-broke.packrat.pages.dev

View logs

@Tadjaur Tadjaur linked an issue Jul 21, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 21, 2024

❌ Tests failed for this pull request. 😞

View Test Workflow

Copy link

github-actions bot commented Jul 21, 2024

Android APK build completed!
You can download the APK file from the following link:
https://github.com/andrew-bierman/PackRat/actions/runs/10030144645#artifacts

Copy link
Collaborator

@JewelTee JewelTee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tadjaur hi! Downloaded Maps screen is empty even after successfully downloading a map.
Screenshot_2024-07-22-00-10-21-11_248012cd4184c9416d967f4c08ee0567

@EngrAJ8888
Copy link
Collaborator

Hi @Tadjaur, experienced the same issue. The "Download Maps' is empty.

@Tadjaur
Copy link
Collaborator Author

Tadjaur commented Jul 21, 2024

Hi @Tadjaur, experienced the same issue. The "Download Maps' is empty.

Yes, this PR needs a server deployment.

@Tadjaur Tadjaur force-pushed the fix-native-map-download branch from 8dd3a55 to 7387eed Compare July 21, 2024 17:29
@github-actions github-actions bot added the test label Jul 21, 2024
@Tadjaur Tadjaur changed the base branch from andrew_testing to server/save-downloaded-map-in-user-profile July 21, 2024 17:30
@Tadjaur
Copy link
Collaborator Author

Tadjaur commented Jul 21, 2024

I've split this PR into two for easier review.

Base automatically changed from server/save-downloaded-map-in-user-profile to andrew_testing July 22, 2024 01:59
@andrew-bierman
Copy link
Owner

Server is deployed

@JewelTee
Copy link
Collaborator

@Tadjaur Download Maps Screen is fixed now. Thank You!

@EngrAJ8888 please verify it on your end as well :)

@EngrAJ8888
Copy link
Collaborator

Hi @Tadjaur @JewelTee, the download maps feature in the native app is now working on my end as well. After reinstalling the app, downloaded maps are saving correctly to my account.

@andrew-bierman this is ready to merge.

Thank you!

@andrew-bierman andrew-bierman merged commit f58d450 into andrew_testing Jul 22, 2024
16 of 38 checks passed
@andrew-bierman andrew-bierman deleted the fix-native-map-download branch July 22, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: Downloaded Maps Not Saving in User Accounts
4 participants