Bug 1 #9
Open
Bug 1 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rckwzrd
commented
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented bed thickness calculations with trig functions in
petrophys_notebook. Added GRAPI unit totest_06. Wrotetest_07to check thickness quantity string representation returned withnp.cos(). Not sure if the test is also valid for the actual value.Realized that the thickness calculations obey dimensional rules for transcendental functions. Only angles in radians are passed to trig functions. If angles are being sought with inverse trig functions, rules still hold because unitless thickness ratios will be passed. Closing corresponding issues... for now.
Did not see any other issues. May need to check my usage of
quantity_maker()when time permits.