NOT TESTED! Implement make_assignable and revert_assignable commands #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent vulnerability, when other side sends object of different type, which will be incorrectly interpolated by the code. The most grave example is when other side send a number, and local code interprets it as an pointer to a string while accessing ->u. Signed-off-by: Volodymyr Babchuk <[email protected]>
Add protocol for two more commands, one to make a PCI device assignable, and other - to revert its state back. Signed-off-by: Volodymyr Babchuk <[email protected]>
Signed-off-by: Volodymyr Babchuk <[email protected]>
Not all commands provide additional response fields, so make this an optional parameter. Signed-off-by: Volodymyr Babchuk <[email protected]>
Implement commands MAKE_ASSIGNABLE and REVERT_ASSIGNABLE in pcid in the same way as they were implemented in libxl_pci.c Replace original logic in libxl_pci.c by calling appropriate functions from pcid. This is quite huge patch, as lots of code were moved from lixbl_pci.c to libxl_pcid.c. Signed-off-by: Volodymyr Babchuk <[email protected]> --- Not tested. Use at own risk. Also, we need to reconsider storing old driver name in xenstore. As pcid is lasting process, we can implement some map and store this information in memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least it compiles :)
Had no time to recreate setup with a new xenpcid, sorry