Skip to content

Commit

Permalink
libxl: remove extraneous arguments to do_pci_remove() in libxl_pci.c
Browse files Browse the repository at this point in the history
Both 'domid' and 'pci' are available in 'pci_remove_state' so there is no
need to also pass them as separate arguments.

Signed-off-by: Paul Durrant <[email protected]>
Reviewed-by: Oleksandr Andrushchenko <[email protected]>
Acked-by: Wei Liu <[email protected]>
  • Loading branch information
Paul Durrant authored and Oleksandr Andrushchenko committed Dec 9, 2020
1 parent 1ba49ff commit bdd3b13
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions tools/libs/light/libxl_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -1871,14 +1871,14 @@ static void pci_remove_stubdom_done(libxl__egc *egc,
static void pci_remove_done(libxl__egc *egc,
pci_remove_state *prs, int rc);

static void do_pci_remove(libxl__egc *egc, uint32_t domid,
libxl_device_pci *pci, int force,
pci_remove_state *prs)
static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs)
{
STATE_AO_GC(prs->aodev->ao);
libxl_ctx *ctx = libxl__gc_owner(gc);
libxl_device_pci *assigned;
uint32_t domid = prs->domid;
libxl_domain_type type = libxl__domain_type(gc, domid);
libxl_device_pci *pci = prs->pci;
int rc, num;
uint32_t domainid = domid;

Expand Down Expand Up @@ -2275,7 +2275,6 @@ static void device_pci_remove_common_next(libxl__egc *egc,
EGC_GC;

/* Convenience aliases */
libxl_domid domid = prs->domid;
libxl_device_pci *const pci = prs->pci;
libxl__ao_device *const aodev = prs->aodev;
const unsigned int pfunc_mask = prs->pfunc_mask;
Expand All @@ -2293,7 +2292,7 @@ static void device_pci_remove_common_next(libxl__egc *egc,
} else {
pci->vdevfn = orig_vdev;
}
do_pci_remove(egc, domid, pci, prs->force, prs);
do_pci_remove(egc, prs);
return;
}
}
Expand Down

0 comments on commit bdd3b13

Please sign in to comment.