Ttva 105 securitas integration #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjacob-anders
force-pushed
the
ttva-105-securitas-integration
branch
4 times, most recently
from
b86a9e6
to
483e84d
Compare
danjacob-anders
force-pushed
the
ttva-105-securitas-integration
branch
from
b8c812f
to
3dcfaec
Compare
danjacob-anders
force-pushed
the
ttva-105-securitas-integration
branch
from
3dcfaec
to
f93ab93
Compare
danjacob-anders
commented
Nov 28, 2023
danjacob-anders
commented
Nov 28, 2023
danjacob-anders
commented
Nov 28, 2023
danjacob-anders
commented
Nov 28, 2023
danjacob-anders
commented
Nov 28, 2023
kulkunen/drivers/securitas.py
Outdated
| response.raise_for_status() | ||
| return response | ||
| except requests.RequestException as e: | ||
| print(params) |
There was a problem hiding this comment.
These print statements can probably be removed now, used for debugging in QA.
danjacob-anders
commented
Nov 28, 2023
kulkunen/drivers/securitas.py
Outdated
| response.raise_for_status() | ||
| return response | ||
| except requests.RequestException as e: | ||
| print(e) |
There was a problem hiding this comment.
These print statements can probably be removed now, used for debugging in QA.
danjacob-anders
commented
Nov 28, 2023
jopesy
reviewed
Nov 29, 2023
locale/fi/LC_MESSAGES/django.po
Outdated
| msgstr "Perinteinen avain/tunnistelätkä" | ||
|
|
||
| msgid "Security guard/janitor" | ||
| msgstr "Vahtimestari/Valvooja" |
There was a problem hiding this comment.
Suggested change
| msgstr "Vahtimestari/Valvooja" | |
| msgstr "Vahtimestari/Valvoja" |
jopesy
reviewed
Nov 30, 2023
jopesy
reviewed
Nov 30, 2023
Refs: TTVA-105
Module formatted with isort and black. Refs: TTVA-105
Refs: TTVA-105
Refs: TTVA-105
This also tidies up existing admin classes. Refs: ttva-105-securitas-integration
In Django or Respa admin one or more access methods can be added to a Resource. Refs: TTVA-105
Refs: TTVA-105
Refs: TTVA-105
Refs: TTVA-105
logger.exception() should pass the Exception instance Refs: TTVA-105
This migration includes merge of SAP and Kulkunen migrations. Refs: TTVA-105
to obtain mobile access for resource Refs: TTVA-105
danjacob-anders
force-pushed
the
ttva-105-securitas-integration
branch
2 times, most recently
from
6efe0b1
to
5728f17
Compare
danjacob-anders
force-pushed
the
ttva-105-securitas-integration
branch
2 times, most recently
from
dac789c
to
2a12960
Compare
removing grant. Additional tests added to check for the group_id. Note that Kulkunen does have validation endpoints, but these do not appear to be called by the management command or elsewhere e.g. Django admin. A future addition should integrate these into the Django admin to prevent runtime issues with misconfiguration. Refs: TTVA-105
danjacob-anders
force-pushed
the
ttva-105-securitas-integration
branch
from
2a12960
to
602d413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.