Ttva 146 sap xml doc #155
Merged
Ttva 146 sap xml doc #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjacob-anders
force-pushed
the
ttva-146-sap-xml-doc
branch
7 times, most recently
from
bea2e96
to
d8bfb31
Compare
danjacob-anders
commented
Aug 7, 2023
danjacob-anders
commented
Aug 7, 2023
danjacob-anders
commented
Aug 7, 2023
danjacob-anders
force-pushed
the
ttva-146-sap-xml-doc
branch
3 times, most recently
from
38392c4
to
2da3971
Compare
This field should be set when admin approves of an invoice request. This field can also be used for logic in determining when to generate a new invoice SAP XML document. Refs: TTVA-146
This timestamp ensures that XML documents for SAP are not sent/created more than once. Refs: TTVA-146
When a reservation of state INVOICE_REQUESTED is confirmed, set timestamps etc. correctly so the invoice can be handled correctly. Refs: TTVA-146
Code formatted with Black/isort Refs: TTVA-146
danjacob-anders
force-pushed
the
ttva-146-sap-xml-doc
branch
from
2da3971
to
6f277e1
Compare
This field should be used to map to the <ProfitCenter> and <SalesOrganization> elements in the SAP xml document. Refs: TTVA-146
…n Unit form Also included optimization to prefetch munipality translations for select field (was over 600+ queries). Refs: TTVA-146
danjacob-anders
force-pushed
the
ttva-146-sap-xml-doc
branch
from
6f277e1
to
6989331
Compare
jopesy
reviewed
Aug 8, 2023
sap_invoices module for handling logic. Refs: TTVA-146
Code formatted with isort/Black Refs: TTVA-146
This value is required for XML SAP sales order generation. Refs: TTVA-146
danjacob-anders
force-pushed
the
ttva-146-sap-xml-doc
branch
from
6989331
to
434056f
Compare
jopesy
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://andersinno.atlassian.net/jira/software/c/projects/TTVA/boards/11?modal=detail&selectedIssue=TTVA-146
This PR includes the following changes:
The XML files for now are written to file by a Django command. It is expected that this command will be updated to also dispatch the invoices via FTP to TietoEvry (or other provider) in a subsequent ticket. Some values have been added to the XML document where possible, otherwise dummy placeholder values have been used.