-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#115230531 Forgot Password #47
Open
lewisemm
wants to merge
14
commits into
develop
Choose a base branch
from
ft-forgot-password-115230531
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisemm
force-pushed
the
ft-forgot-password-115230531
branch
2 times, most recently
from
April 6, 2016 06:37
5f195d6
to
4e64f48
Compare
- Create a link at the login page to start the reset password process - The link is clicked to call a modal dialog. This dialog has a field where the email of the user whose password is being reset is typed in - Configure the modal dialog's max-height to 90% to provide more space to the elements within and reduce clutter
- Create a password reset model to store request details in the database for verification and updating when during completion process - Create a html template to be used in the PasswordReset model - Create a serializer, viewset and register an API route to manage this model using REST
- Change the link in the 'Reset Password' button in the reset email. The previous link used to redirect to the api backend. The change redirects to a url that maps to a view - Update the limber.urls file to handle the password completion process by redirecting to the 'password_reset_completion' view - Create the 'password_reset_completion' view
- Refactor the create method of PasswordResetViewset. This method has been defined to accept wither a 'user' (id) or 'an email' address. When an email is given, it queries the UserAuthentication model to get the user associated with the provided email and uses his/her id in the serializer - Include the 'request_date' as a read only field to enforce the current date as the value of this field - Adjust the authController to send the email data under the email key - Create a PasswordReset resource to handle calls to the '/api/password/ reset/' route in the backend
- Move the html definition of the 'forgot password' modal to within the scope of the controller so that programmatic activation is possible
Fix indentation and spacing in html code for layout page
- Create an update method that requires a 'new_password' argument to change the password of the user associated with the PasswordReset object - Create PUT functionality for PasswordReset resource in mainService
- Create the password reset controller to handle requests from the password reset view - Load the password reset controller in the parent view (layout.html) - Include the password reset controller in the password reset view
- Fix error code to HTTP 404 when a PasswordRequest object is not found
- Create tests for the forgot password functionality.
- Center password reset form, use border, provide 'Limber' header for navigation to the root url
- Define logic to check whether password request has been used before attempting to update the password - Fix bug at the PasswordReset model by checking whether the request has been used before prior to sending reset email - Display toast in the password reset view informing user that a request has expired if it has been used before - Create tests for a scenario where a user is attempting to re-use a password request. - Create a link to the login page at the password reset page
- Resolve Python 3 compatibility errors
lewisemm
force-pushed
the
ft-forgot-password-115230531
branch
from
December 4, 2016 21:21
f7cc335
to
80e8b50
Compare
@@ -115,7 +115,7 @@ def test_update_password_reset(self): | |||
} | |||
response = self.client.post(login_url, login_data) | |||
self.assertEqual(response.status_code, 200) | |||
self.assertTrue(response.data.has_key('token')) | |||
self.assertTrue('token' in response.data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of the task to be completed?
Forgot Password?
link in the login page. When this link is clicked, a modal dialog is opened and it prompts the user to enter his/her email address.Send Password Reset Email
, one of two things can happen;Reset Password
button in the email, he/she will be redirected to a view where they can type in their preferred password.Reset Password
in the reset password view to complete the process.How should this be manually tested?
Forgot Password
link in the login page to start the reset password process.Any background context you want to provide?
[email protected]
What are the relevant Pivotal Tracker stories?
ID #115230531 - Forgot Password
Screenshot