Adding Group resource #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Aug 19, 2019
onepassword/resource_group.go
Outdated
| } | ||
|
|
||
| d.SetId(v.UUID) | ||
| d.Set("name", v.Name) |
There was a problem hiding this comment.
Error return value of d.Set is not checked (from errcheck)
|
@taiidani greate job. Thank you for your job. |
|
@taiidani sorry for so late reaction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
Proposed Changes
groupresource to the provider, taking inspiration from the existingvaultresource.stateJSON property which helps determine if the group has been deleted or not. This might assist with solving Deleting a Vault from 1Password doesn't trigger recreate #17.