Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Vertex AI (Google) API based fine-tuning #410

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding Vertex AI (Google) API based fine-tuning #410

wants to merge 1 commit into from

Conversation

Aryan8912
Copy link

@Aryan8912 Aryan8912 commented Nov 29, 2023 •
edited
Loading

close #181

VictorOdede
VictorOdede requested changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@VictorOdede VictorOdede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good but this code should be added to the onsite_llm file. Add a base class for the vertex ai models containing the finetuning method then extend the base class for each of the supported vertex ai models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorOdede VictorOdede VictorOdede requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vertex AI (Google) API based fine-tuning
2 participants
@Aryan8912 @VictorOdede