Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selling price & product price #30

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tacomoon
Copy link

@tacomoon tacomoon commented Oct 3, 2020

Add PRODUCT_SELLING_PRICE column, update JPA model.
Add appropriate column to admin views.
Show selling price to customer as strike over.
Update sum formulas.
#29

Add appropriate column to admin views.
Show selling price to customer as strike over.
Update sum formulas.
@anantjain6
Copy link
Owner

@tacomoon First of all thanks for your contribution and sorry for late response

I have following comments:-

  1. add validation that selling price <= product price
  2. In admin panel while viewing product report the total amount is not coming in correct column
    To fix this, in file "src/main/webapp/admin/product/report.jsp" at line 54 you need to change the value of "colspan" to 5

@tacomoon
Copy link
Author

tacomoon commented Oct 8, 2020

@anantjain6 done

@tacomoon
Copy link
Author

@anantjain6 have you checked changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants