Empty Search fix and search edit #408
Conversation
| GestureDetector( | ||
| onTap: () { | ||
| searchScreenController.textInputController.text = | ||
| searchResScrController.queryString.value; | ||
| Navigator.pop(context); | ||
| }, | ||
| child: Column( | ||
| children: [ | ||
| Align( | ||
| alignment: Alignment.centerLeft, | ||
| child: Text( | ||
| "searchRes".tr, | ||
| style: Theme.of(context).textTheme.titleMedium, | ||
| ), | ||
| ), | ||
| Align( | ||
| alignment: Alignment.centerLeft, | ||
| child: Text( | ||
| "${"for1".tr} \"${searchResScrController.queryString.value}\"", | ||
| style: Theme.of(context).textTheme.titleLarge, | ||
| ), | ||
| ), | ||
| ], |
There was a problem hiding this comment.
i think, it is not a good idea to add event on Search result, please keep this part as it was before. many persons also want fields should be cleared after search, & we already have search history implemented.
There was a problem hiding this comment.
If the intention is to edit search string, you can add event only on searched string. So that if any of user want to edit he can be able to do that.
There was a problem hiding this comment.
The intention behind this change is to enable users to directly edit the searched text so that the user does not need to rewrite the text and directly make changes in the searched text. As of now users can only go back and need to retype the text, which isn't a pleasant experience (from my experience as a user). To enable this, I have made this change.
Also the intention behind increasing searched text font size and making the header also tap-able is to increase the touch area, as the user will only hit it when he needs to make change in the entered text, else he can directly go back.
Do let me know if I should revert these changes or make some other changes.
Thanks
These changes makes sure that the user is not able to make empty searches i.e. search for nothing (" ") and also removes leading and trailing spaces from searches, which doesn't look that good (eg below). Beside this, this PR also include change requested in issue #391 and now allows user to edit the searched text by tapping on it.
(A slight change is made in search result header, making the actual searched text bigger and making the 'Search results' text smaller, as it seemed a bit more logical to me to highlight the actual text)