fix: allow use of qt window decorations #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Flutter defaults to always using GTK window decorations regardless of the window manager, when running Wayland. This makes the app look out of place on KDE Plasma and other Qt-based desktop environments. This change checks the XDG_CURRENT_DESKTOP environment variable to determine the running desktop environment, and if it is GNOME continues to use the GTK header, otherwise it uses the Qt header.
|
@Merrit thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Flutter defaults to always using GTK window decorations regardless of
the window manager, when running Wayland. This makes the app look out of place
on KDE Plasma and other Qt-based desktop environments.
This change checks the XDG_CURRENT_DESKTOP environment variable to determine the
running desktop environment, and if it is GNOME continues to use the GTK header,
otherwise it uses the Qt header.
Now in the
afterscreenshot, the window has native decorations on KDE with user-customized controls for things likepin to all workspaces.