fix: system tray causing crash on linux #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [system_tray](https://pub.dev/packages/system_tray) package appears abandoned, with no update or comments for 13 months. The issue this PR fixes is due to a known bug in the system_tray package: antler119/system_tray#64 This PR replaces the system_tray package with the [tray_manager](https://pub.dev/packages/tray_manager) package, which is actively maintained and doesn't cause the crash. `tray_manager` has beem around for 3+ years and had a release just 11 days ago. Resolves anandnet#232
Merrit
commented
May 30, 2024
Comment on lines
+88
to
+108
| @override | ||
| void onTrayIconMouseDown() { | ||
| if (GetPlatform.isWindows) { | ||
| windowManager.show(); | ||
| } else { | ||
| trayManager.popUpContextMenu(); | ||
| } | ||
|
|
||
| super.onTrayIconMouseDown(); | ||
| } | ||
|
|
||
| @override | ||
| void onTrayIconRightMouseDown() { | ||
| if (GetPlatform.isWindows) { | ||
| trayManager.popUpContextMenu(); | ||
| } else { | ||
| windowManager.show(); | ||
| } | ||
|
|
||
| super.onTrayIconRightMouseDown(); | ||
| } |
There was a problem hiding this comment.
I'm not certain this is the click behaviour we want, I simply reproduced what we currently had.
Personally, I think left-click to show/hide and right-click for context menu sounds quite appropriate and expected (speaking as a full-time Linux user).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system_tray package appears abandoned, with no update or comments for 13 months. The issue this PR fixes is due to a known bug in the system_tray package: antler119/system_tray#64
This PR replaces the system_tray package with the tray_manager package, which is actively maintained and doesn't cause the crash.
tray_managerhas beem around for 3+ years and had a release just 11 days ago.tray_manageris also a sibling package to thewindow_managerpackage already being used.Resolves #232