refactor(Examples): Update examples with CLI to use new CLI library #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
MAX32650
sihyung-maxim
approved these changes
Oct 31, 2023
| @@ -6,8 +6,8 @@ Below is a list of the supported commands: | |||
| * help: Prints out the list of available commands and describes how each command is used. | |||
| * stop: Ends the example. | |||
| * read: Reads data from a file and prints it to the terminal. | |||
| * write: Writes data to a file and can optionally create the file to write to if it does not already exist. | |||
| * swl: Stands for "show wear leveling". This command performs a specified number of writes (passed as an argument on the command line) to a test file and prints out the number of times each filesystem block was written to. Users should see the writes occur somewhat evenly across most filesystem blocks. | |||
| * write: Writes a characterstring to a file | |||
There was a problem hiding this comment.
Missing space in characterstring?
Comment on lines
+63
to
+60
| // Macro to call MXC_UART_Init function with appropriate parameters | ||
| #if (TARGET_NUM == 32520 || TARGET_NUM == 32570 || TARGET_NUM == 32650) | ||
| #define UART_INIT(uart) MXC_UART_Init(uart, UART_BAUD) | ||
| #elif TARGET_NUM == 32660 | ||
| #define UART_INIT(uart) MXC_UART_Init(uart, UART_BAUD, MAP_A) | ||
| #elif TARGET_NUM == 32662 | ||
| #define UART_INIT(uart) MXC_UART_Init(uart, UART_BAUD, MXC_UART_APB_CLK, MAP_A) | ||
| #else | ||
| #define UART_INIT(uart) MXC_UART_Init(uart, UART_BAUD, MXC_UART_APB_CLK) | ||
| #endif |
There was a problem hiding this comment.
Good example related to #787
lorne-maxim
approved these changes
Nov 13, 2023
Jake-Carter
approved these changes
Nov 15, 2023
4 tasks
Jake-Carter
force-pushed
the
dev/update_cli_examples
branch
from
c453a4b
to
b4ae16b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will eventually update all Flash_CLI, WearLeveling, and SDHC_FAT examples to use the new CLI library. For now, I have updated one of each of these examples. Once I have initial approval of these updated examples and #769 has been approved and merged, then I will add these updates to the remainder of the chips which support the examples.