fix(workflow): Fix globstar paths in labeler workflow and revise PR template #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihyung-maxim
changed the title
sihyung-maxim
changed the title
Jake-Carter
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
I think the maintenance overhead of this workflow has outweighed its usefulness so far.
It will be more valuable when we start auto-generating the release notes, but that's also something we still need to implement.
| - '*Libraries/BlePhy/*' | ||
| - '*Libraries/Cordio/*' | ||
| - '*Tools/Bluetooth/*' | ||
| - '**/Examples/**/BLE*/**/*' |
There was a problem hiding this comment.
Doesn't make sense that we would need to start this with a recursive glob. Assuming you've already tried Examples/**/... and it didn't work I guess this is fine if it gets the workflow to behave.
There was a problem hiding this comment.
Usually, there's no need to, but I noticed the location of the runner when it checks out the HEAD can sometimes vary between inside or outside the directory repo
ftariqAnalogTx
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the globstar paths for the labeler workflow. Hopefully, it should work now.
Also, revised the PR template.
Checklist Before Requesting Review