fix(Boards): Add weak definition of GPIO0 IRQ handler to MAX32665's MAXREFDES178 BSP #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacob-Scheiffler
changed the title
Jacob-Scheiffler
requested review from
Jake-Carter,
lorne-maxim and
sihyung-maxim
and removed request for
lorne-maxim
Jake-Carter
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Agreed we should also fix this in the refdes repo
@vicloginov seems to be some issues with OV5640_DVP logic for AI87 CSI driver builds as of #644. Not sure how this slipped through the build autotests
@Jacob-Scheiffler I'm investigating the build failure now...
MAX78002 (EvKit_V1): CameraIF failed.
Build command: make -r -j 8 --output-sync=target --no-print-directory TARGET=MAX78002 MAXIM_PATH=/home/runner/work/msdk/msdk BOARD=EvKit_V1 FORCE_COLOR=1
Errors:
----------------------------------------
/home/runner/work/msdk/msdk/Libraries/MiscDrivers/Camera/mipi_camera.c: In
function 'mipi_camera_init':
/home/runner/work/msdk/msdk/Libraries/MiscDrivers/Camera/mipi_camera.c:264:41:
error: 'mipi_camera_settings_t' {aka 'struct _mipi_camera_settings_t'} has no
member named 'line_handler'
264 | g_req.line_handler = camera_settings.line_handler;
| ^
make: ***
[/home/runner/work/msdk/msdk/Libraries/CMSIS/Device/Maxim/GCC/gcc.mk:299:
/home/runner/work/msdk/msdk/Examples/MAX78002/CameraIF/build/mipi_camera.o]
Error 1
make: *** Waiting for unfinished jobs....
----------------------------------------
|
Build error fixed in #667 |
sihyung-maxim
approved these changes
Jul 13, 2023
sihyung-maxim
changed the title
Jacob-Scheiffler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrating the PushButton code to MiscDrivers caused existing cube camera projects to hang because they relied on the GPIO0_IRQHandler defined in the old implementation of pb.c. This GPIO handler was not included in the MAX32665's MAXREFDES178 BSP because it does not have any push buttons connected to GPIO0. This PR adds a weak definition to the MAX32665's MAXREFDES178 BSP to support the legacy implementation while cube camera projects get updated with their own definition of GPIO0_IRQHandler.
Issue #49 has been submitted to the MaximIntegratedAI/refdes repo to request the GPIO0_IRQHandler get added to each of their projects, however this change should still be added in the meantime because it doesn't seem like anybody has been maintaining that repo.
Checklist Before Requesting Review