fix(Boards): Add GPIO2_IRQ_Handler for MAX78000 FTHR_RevA #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Carter
approved these changes
Oct 9, 2024
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
One of the customers reported that they can't use P2.3 pin on MAX78000 FTHR even they enable interrupt and configure callback function. Interrupt is not triggered, and callback function is not called.
I figured out that GPIO2_IRQ_Handler was not defined even as a weak function in board.c file. I thought it might be better to have a weak definition for GPIO2 interrupts as well. So, users can also override this function in their application if needed.