fix(PeriphDrivers): Corrected pin definitions for BLE chips #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricB-ADI
changed the title
kevin-gillespie
approved these changes
Sep 25, 2024
kevin-gillespie
approved these changes
Sep 25, 2024
EricB-ADI
changed the title
sihyung-maxim
approved these changes
Sep 25, 2024
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses issues #1182 and #1181
The pins definition for the external clock was wrong.
It is only available on P0.3, not P0.12 and P0..13. Furthermore, the alternate function was wrong. It is ALT1 not ALT2
The image above is for the WLP, but the pin mapping is true for all package variants.
Antenna control 0 and 1 was flipped for ME18