Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BLE): ME18 PHY + PAL UART + clean.cordio #1080

Merged
merged 26 commits into from
Jul 25, 2024
Merged

fix(BLE): ME18 PHY + PAL UART + clean.cordio #1080

merged 26 commits into from
Jul 25, 2024

Conversation

EricB-ADI
Copy link
Contributor

@EricB-ADI EricB-ADI commented Jul 11, 2024

Description

ME18 PHY

The ME18 PHY was showing some issues in stability. This build is the most up to date and stable PHY we have.

PAL UART

PAL UART triggers an assertion by default anytime an error occurs. Now if it is in on the console or the HCI UART, the FIFO is flushed and we continue. Cordio has no mechanism to bubble the error back up, so if an error occurs on HCI, two errors will always occur unless extremely lucky.
The first error is the actual error from reported by the hardware. The second error is Cordio not being able to recreate an HCI packet since, the packet is incomplete as the previous partial segment is being added to the new segment.
After this error it starts over and goes back to normal.

The error always seems to be an overflow error. The best solution for this is to enable HW flow control.

clean.cordio

Fixed clean.cordio recipe in libCordio.mk. The MAXIM_PATH is not properly being passed down, so if you do not have the MAXIM_PATH set as an environment variable, clean.cordio does not work. CMSIS_PATH is set so I just used a relative path from that.

@EricB-ADI EricB-ADI changed the title Fix/me18 phy fix(BLE): ME18 PHY and clean.cordio Jul 11, 2024
@github-actions github-actions bot added the BLE Related to Bluetooth label Jul 11, 2024
@EricB-ADI EricB-ADI changed the title fix(BLE): ME18 PHY and clean.cordio fix(BLE): ME18 PHY + PAL UART + clean.cordio Jul 12, 2024
@github-actions github-actions bot added the MAX32655 Related to the MAX32655 (ME17) label Jul 18, 2024
@github-actions github-actions bot removed the MAX32655 Related to the MAX32655 (ME17) label Jul 19, 2024
@github-actions github-actions bot added the MAX32690 Related to the MAX32690 (ME18) label Jul 19, 2024
@EricB-ADI
Copy link
Contributor Author

/clang-format-run

@github-actions github-actions bot added the MAX32655 Related to the MAX32655 (ME17) label Jul 19, 2024
@kevin-gillespie
Copy link
Contributor

Not sure if disabling the terminal echo will help with our test automation. I can't tell if the tests now are failing because of the UART in general, the echo, or BLE disconnects.

diff --git a/Libraries/Cordio/wsf/sources/util/terminal.c b/Libraries/Cordio/wsf/sources/util/terminal.c
index 7d97f548ff..85a8e10ade 100644
--- a/Libraries/Cordio/wsf/sources/util/terminal.c
+++ b/Libraries/Cordio/wsf/sources/util/terminal.c
@@ -101,7 +101,7 @@ void TerminalInit(wsfHandlerId_t handlerId)
   terminalCb.handlerId     = handlerId;
   terminalCb.pFirstCommand = NULL;
   terminalCb.isExecuting   = FALSE;
-  terminalCb.doEcho        = TRUE;
+  terminalCb.doEcho        = FALSE;
   terminalCb.bufOffset     = 0;
 
   TerminalRegisterCommand(&terminalCommandHelp);

@EricB-ADI
Copy link
Contributor Author

/clang-format-run

@EricB-ADI
Copy link
Contributor Author

/clang-format-run

@EricB-ADI EricB-ADI merged commit b47c56e into main Jul 25, 2024
8 of 9 checks passed
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Jul 25, 2024
EricB-ADI added a commit that referenced this pull request Aug 21, 2024
Co-authored-by: Kevin Gillespie <[email protected]>
Co-authored-by: EricB-ADI <[email protected]>
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
ozersa pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 11, 2024
ozersa pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLE Related to Bluetooth MAX32655 Related to the MAX32655 (ME17) MAX32690 Related to the MAX32690 (ME18)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants