fix(PeriphDrivers): Fix -wstrict-prototype and other Misc. MAX78002 Warnings
#1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change MXC_CSI2_CaptureFrame prototype to no longer accept the number of data lanes as an argument. The number of data lanes is configured at initialization time. This is a low risk change, as it was previously non-functional and unused.
sihyung-maxim
approved these changes
Jul 9, 2024
|
Can you wait to merge until this PR is in: #1076? Want to test if changes from a forked branch are properly pushed into the zephyr-hal repo. |
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Jul 9, 2024
ozersa
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 11, 2024
ozersa
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Primarily fixes
-wtrict-prototypewarnings for the MAX78002 peripheral driver builds. While I was at it I also fixed double promotion and some other misc. warnings in the examples.The build system now skips CSI2 and mxc_lock driver files for RISC-V builds (i.e. when
RISCV_CORE = 1) to avoid those warnings as well.Checklist Before Requesting Review