Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(PeriphDrivers): Revert incorrect spi_num - reqselTx/Rx matching in DMA-based SPI transactions for MAX32655, MAX32662, MAX32680, MAX78000, and MAX78002 #1072

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

JeonChangmin
Copy link
Contributor

Description

This pull request reverts the commit that attempted to fix the spi_num and reqselTx/Rx matching in DMA-based SPI transactions. The previous fix was incorrect due to a misunderstanding of the RISC-V architecture implementation.

Reason for Reversion

Upon reviewing the max78000.h file, it was noted that the spi_num and mxc_dma_reqsel_t numbers were intentionally ordered to support both ARM and RISC-V architectures. The mismatched numbers were due to this architectural difference, not an error in the original implementation. By reverting this commit, we restore the original, correct behavior for both architectures. (See max78000.h comment)

Additional Information

Tests

  • Tested the changes on a MAX78000 device to ensure correct behavior of the DMA-based SPI transactions.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

…DMA-based SPI transaction"

This reverts commit 6bcc398.
@github-actions github-actions bot added MAX32655 Related to the MAX32655 (ME17) MAX32680 Related to the MAX32680 (ME20) MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87) MAX32662 Related to the MAX32662 (ME12) labels Jul 3, 2024
@JeonChangmin JeonChangmin changed the title revert(PeriphDrivers): Revert incorrect spi_num - reqselTx/Rx matching in DMA-based SPI transactions revert(PeriphDrivers): Revert incorrect spi_num - reqselTx/Rx matching in DMA-based SPI transactions for MAX32655, MAX32662, MAX32680, MAX78000, and MAX78002 Jul 3, 2024
@sihyung-maxim
Copy link
Contributor

No worries, not your fault. The indexing and names are confusing which should be addressed. Plus, I think my comment was hidden away.

#1059 (comment)

@JeonChangmin
Copy link
Contributor Author

@sihyung-maxim Thank you for your message.

Your previous comment might have been missed due to the resolved conversation.
In this PR, I have included a revert commit to address the mismatch issue from the earlier PR.
Since I might not fully grasp all the device scenarios, it would be great if you could discuss and decide on the best approach internally.

Thank you for your understanding.

Copy link
Contributor

@sihyung-maxim sihyung-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will handle the confusing indexing issues in a separate PR. It's finally time to address these changes.

@sihyung-maxim sihyung-maxim merged commit 713cf98 into analogdevicesinc:main Jul 8, 2024
10 checks passed
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
…g in DMA-based SPI transactions for MAX32655, MAX32662, MAX32680, MAX78000, and MAX78002 (#1072)
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
… matching in DMA-based SPI transactions for MAX32655, MAX32662, MAX32680, MAX78000, and MAX78002 (#1072)"

This reverts commit 713cf98.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32655 Related to the MAX32655 (ME17) MAX32662 Related to the MAX32662 (ME12) MAX32680 Related to the MAX32680 (ME20) MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants