Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTC: MAX31331: Support and documentation for RTC MAX31331 #2593

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

RTC: MAX31331: Support and documentation for RTC MAX31331 #2593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d113b40
rtc:max31331:Support for RTC MAX31331
SwaroopPKADI Sep 6, 2024
9030670
devicetree:rtc:max31331:Update documentation for max31331
SwaroopPKADI Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions Documentation/devicetree/bindings/rtc/adi,max31335.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,37 @@ description:
allOf:
- $ref: rtc.yaml#

- if:
properties:
compatible:
contains:
enum:
- adi,max31335
then:
properties:
reg:
items:
- const: 0x69
else:
properties:
reg:
items:
- const: 0x68
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, typically, this comes after required: but I see that you're already making use of allOf: here. Maybe it's acceptable to move it to the end. Not sure, up to you...


properties:
compatible:
const: adi,max31335
enum:
- adi,max31331
- adi,max31335

reg:
maxItems: 1
description: I2C address of the RTC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for description

items:
- enum: [0x68, 0x69]

interrupts:
description: |
Alarm1 interrupt line of the RTC.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

maxItems: 1

"#clock-cells":
Expand Down Expand Up @@ -59,7 +82,7 @@ examples:

rtc@68 {
compatible = "adi,max31335";
reg = <0x68>;
reg = <0x69>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change this. Why going in favor of the new reg? If you really want, add another example for the new device.

pinctrl-0 = <&rtc_nint_pins>;
interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
aux-voltage-chargeable = <1>;
Expand Down
Loading