Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for hsl alpha in attribute/color #954

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

germain-gg
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

Fixing attribute/color so that it work with hsl() colors that have an alpha channel.

The issue lies with tinycolor2 that does not recognise that syntax and fixes the alpha to 1 if hsl() is used. According to the CSS spec, you can specify a fourth argument, so both hsl and hsla should work.

Creating this PR as a draft and I will mark it as ready once bgrins/TinyColor#269 lands


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@germain-gg germain-gg marked this pull request as draft April 5, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant