fix(outputReferences): sorting of token without references #1362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1350 (at least for the outputReferences case)
Issue Summary:
When using the
outputReferences
option, the tokens output is in reversed order compared to the input order. This is due to the end of thesortByReference
method which defines that A comes first by default.Considering the following input :
We end up with :
Description of changes:
At the end of the
sortByReference
method I introduced areturn 0
in order to keep original order for token without reference. I introduced a test for the casebUsesRefs
to still haveA_COMES_FIRST
since it was the previous return value for this case.I also added a unit test for the two tokens without reference case and had to update some snapshot because of the new order. I checked all generated snapshot and the token using a ref is always declared after the referenced token.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.