Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EventBridge Scheduler with model release v1.46.5 (2023-10-26) #96

Merged

Conversation

knovichikhin
Copy link
Contributor

@knovichikhin knovichikhin commented Oct 27, 2023

Issue #, if available:

Description of changes:

Added EventBridge Scheduler. Update to the latest because current model did not yet support automatic schedule deletion (https://github.com/aws/aws-sdk-go/blob/886c1752c1f070abab22aea4c2b6e17aa7090b04/models/apis/scheduler/2021-06-30/api-2.json#L325C67-L325C67)

A matching PR for smoke-aws amzn/smoke-aws#144

Testing:

Created a test schedule:

2023-10-26T23:08:24-0400 trace: outgoingEndpoint=https://scheduler.us-west-2.amazonaws.com:443/schedules/test-schedule outgoingRequestId=9E7E2E84-168A-42F1-A5D2-5E576AC7BBD7 [SmokeHTTPClient] Sending POST request to endpoint: https://scheduler.us-west-2.amazonaws.com:443/schedules/test-schedule at path: /schedules/test-schedule.
2023-10-26T23:08:24-0400 trace: outgoingEndpoint=https://scheduler.us-west-2.amazonaws.com:443/schedules/test-schedule outgoingRequestId=9E7E2E84-168A-42F1-A5D2-5E576AC7BBD7 [AWSHttp] Target not found for HTTP header, assigning CreateSchedule to x-amzn-target header.
2023-10-26T23:08:24-0400 trace: bodyData={
  "Description" : "...",
  "FlexibleTimeWindow" : {
    "Mode" : "OFF"
  },
  "ScheduleExpression" : "at(2023-10-27T03:15:00)",
  "Target" : {
    "Arn" : "arn:aws:sqs:us-west-2:AWS_ACCT:knov-test-queue",
    "Input" : "this-is-the-message-to-sqs",
    "RoleArn" : "arn:aws:iam::AWS_ACCT:role\/knov-test-role"
  },
  "ActionAfterCompletion" : "DELETE",
  "ClientToken" : "idempotency-token"
} bodyDataSize=416 method=POST outgoingEndpoint=https://scheduler.us-west-2.amazonaws.com:443/schedules/test-schedule outgoingRequestId=9E7E2E84-168A-42F1-A5D2-5E576AC7BBD7 uri=https://scheduler.us-west-2.amazonaws.com:443/schedules/test-schedule [AWSHttp] Starting outgoing request.
2023-10-26T23:08:25-0400 trace: bodyData={"ScheduleArn":"arn:aws:scheduler:us-west-2:AWS_ACCT:schedule/default/test-schedule"} bodyDataSize=89 code=200 outgoingEndpoint=https://scheduler.us-west-2.amazonaws.com:443/schedules/test-schedule outgoingRequestId=9E7E2E84-168A-42F1-A5D2-5E576AC7BBD7 x-amz-request-id=d8ea794d-0cd4-42aa-b48f-79f04c6e162c [AWSHttp] Successfully completed outgoing request.
2023-10-26T23:08:25-0400 trace: body={"ScheduleArn":"arn:aws:scheduler:us-west-2:AWS_ACCT:schedule/default/test-schedule"} outgoingEndpoint=https://scheduler.us-west-2.amazonaws.com:443/schedules/test-schedule outgoingRequestId=9E7E2E84-168A-42F1-A5D2-5E576AC7BBD7 [AWSHttp] Attempting to decode result data from JSON to CreateScheduleOutput
▿ SchedulerModel.CreateScheduleOutput
  - scheduleArn: "arn:aws:scheduler:us-west-2:AWS_ACCT:schedule/default/test-schedule"

Can also see that the errors are handled:

2023-10-26T23:10:44-0400 trace: body={
  "__type" : "ConflictException",
  "Message" : "Schedule test-schedule already exists."
} outgoingEndpoint=https://scheduler.us-west-2.amazonaws.com:443/schedules/test-schedule outgoingRequestId=F01EA6F5-CB94-4890-9E86-26E584A8279D [AWSHttp] Attempting to decode error data from JSON to SchedulerError.
2023-10-26T23:10:44-0400 trace: bodyData={"Message":"Schedule test-schedule already exists."} bodyDataSize=52 code=409 error=HTTPClientError(responseCode: 409, cause: SchedulerModel.SchedulerError.conflict(SchedulerModel.ConflictException(message: "Schedule test-schedule already exists."))) outgoingEndpoint=https://scheduler.us-west-2.amazonaws.com:443/schedules/test-schedule outgoingRequestId=F01EA6F5-CB94-4890-9E86-26E584A8279D x-amz-request-id=4e484533-7959-4b17-ac7a-860b137e87cb [AWSHttp] Unsuccessfully completed outgoing request.
2023-10-26T23:10:44-0400 trace: outgoingEndpoint=https://scheduler.us-west-2.amazonaws.com:443/schedules/test-schedule outgoingRequestId=F01EA6F5-CB94-4890-9E86-26E584A8279D [SmokeHTTPClient] Request not retried due to error returned: HTTPClientError(responseCode: 409, cause: SchedulerModel.SchedulerError.conflict(SchedulerModel.ConflictException(message: "Schedule test-schedule already exists.")))
BackfillPASCAEManifestsAndRefreshBoundaryReports terminated with an error.
▿ SchedulerModel.SchedulerError.conflict
  ▿ conflict: SchedulerModel.ConflictException
    - message: "Schedule test-schedule already exists."

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@tachyonics tachyonics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@knovichikhin knovichikhin merged commit 0ad25ea into amzn:smoke-aws-generate-2.x Oct 27, 2023
3 checks passed
@knovichikhin knovichikhin deleted the smoke-aws-generate-2.x branch October 27, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants