re auth #4190
Open
re auth #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b856edd.
…schange-schema' into pr/4068
Removing extra note on throttling rate
Clarify availability of ElectronicInvoiceStatus
…schange-schema' into pr/4068
…rChangedNotification schema
…Notification schema" This reverts commit 80d7964.
…Notification schema" This reverts commit 80d7964.
commit 2b183a1 Author: Denis Garcia <[email protected]> Date: Sun Aug 25 07:57:13 2024 +0100 Update README.md fix a few typos in selling-partner-api-models/clients/sellingpartner-api-aa-javascript/README.md
There are many schemas that include `"default": {}` for keys of type
object, that include required keys, making that default value invalid.
Removing these invalid defaults fixes the schema conversion using tools
like `go-jsonschema` [1], as now it understands the object cannot be
empty.
[1] https://github.com/omissis/go-jsonschema
Signed-off-by: rubeena begum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.